add uniswapx #42
Merged
add uniswapx #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secmask
reviewed
Apr 25, 2024
pkg/parser/uniswapx/parser.go
Outdated
| ErrInvalidOneInchFilledTopic = errors.New("invalid uniswapx order filled topic") | ||
| ErrUpdateOrder = errors.New("can't update order") | ||
|
|
||
| OrderTuple, _ = abi.NewType("tuple", "", []abi.ArgumentMarshaling{ |
There was a problem hiding this comment.
ignore err somehow still not a good practice, how about init it in parser constructor?
There was a problem hiding this comment.
@secmask error only happen when fail to create ABI type. But we create static type, so it never happen.
https://gist.github.com/fxfactorial/475bf4a50d0f9f6653b4dc4b610d86cd#file-example-go-L13
Anyway, I fixed it.
secmask
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add uniswapx parser
Limit re-parse error log